Return UNIX_TIMESTAMP as Python datetime
#2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judahrand
added
kind/bug
kind/feature
judahrand
force-pushed
the
unix-timestamp
branch
from
b94c29e to
dc6c522
Compare
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
judahrand
force-pushed
the
unix-timestamp
branch
from
dc6c522 to
0f7f9b2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2244 +/- ##
===========================================
- Coverage 85.42% 60.14% -25.28%
===========================================
Files 108 108
Lines 9027 9028 +1
===========================================
- Hits 7711 5430 -2281
- Misses 1316 3598 +2282
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
judahrand
force-pushed
the
unix-timestamp
branch
from
dd3f75a to
d035831
Compare
Signed-off-by: Judah Rand <[email protected]>
Signed-off-by: Judah Rand <[email protected]>
judahrand
force-pushed
the
unix-timestamp
branch
from
d035831 to
899e4e3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, judahrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
feast-ci-bot
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Add backticks to left_table_query_string (#2250) Signed-off-by: david <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Delete entity key from Redis only when all attached feature views are gone (#2240) * Delete entity from redis when the last attached feature view is deleted Signed-off-by: pyalex <[email protected]> * Delete entity key from Redis only when all attached feature views are gone Signed-off-by: pyalex <[email protected]> * make lint happy Signed-off-by: pyalex <[email protected]> * make lint happy Signed-off-by: pyalex <[email protected]> * one more try with mypy Signed-off-by: pyalex <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * historical_field_mappings2 merge for one sign off commit (#2252) Signed-off-by: Michelle Rascati <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Correct inconsistent dependency (#2255) Signed-off-by: Judah Rand <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Add snowflake environment variables to allow testing on snowflake infra (#2258) * add snowflake environment vars to test framework Signed-off-by: sfc-gh-madkins <[email protected]> * add snowflake environment vars to test framework Signed-off-by: sfc-gh-madkins <[email protected]> * Return `UNIX_TIMESTAMP` as Python `datetime` (#2244) * Refactor `UNIX_TIMESTAMP` conversion Signed-off-by: Judah Rand <[email protected]> * Return `UNIX_TIMESTAMP` types as `datetime` to user Signed-off-by: Judah Rand <[email protected]> * Fix linting errors Signed-off-by: Judah Rand <[email protected]> * Rename variable to something more sensible Signed-off-by: Judah Rand <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Feast plan clean up (#2256) * Run validation and inference on views and entities during plan Signed-off-by: Felix Wang <[email protected]> * Do not log objects that are unchanged Signed-off-by: Felix Wang <[email protected]> * Rename Fco to FeastObject Signed-off-by: Felix Wang <[email protected]> * Remove useless method Signed-off-by: Felix Wang <[email protected]> * Lint Signed-off-by: Felix Wang <[email protected]> * Always initialize registry during feature store initialization Signed-off-by: Felix Wang <[email protected]> * Fix usage test Signed-off-by: Felix Wang <[email protected]> * Remove print statements Signed-off-by: Felix Wang <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Squash commits Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Add error type and refactor query execution to have retries Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Handle more snowflake errors Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Fix lint errors Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Fix lint errors Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Fix lint errors Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * Fix wrong import Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * modify registry.db s3 object initialization to work in S3 subdirectory with Java Feast Server (#2259) Signed-off-by: NalinGHub <[email protected]> Signed-off-by: sfc-gh-madkins <[email protected]> * clean up docs Signed-off-by: sfc-gh-madkins <[email protected]> * lint-python Signed-off-by: sfc-gh-madkins <[email protected]> * fixed historical test Signed-off-by: sfc-gh-madkins <[email protected]> * fixed historical test Signed-off-by: sfc-gh-madkins <[email protected]> Co-authored-by: David Miller <[email protected]> Co-authored-by: Oleksii Moskalenko <[email protected]> Co-authored-by: Michelle Rascati <[email protected]> Co-authored-by: Judah Rand <[email protected]> Co-authored-by: Felix Wang <[email protected]> Co-authored-by: Danny Chiao <[email protected]> Co-authored-by: Nalin Mehra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Title is pretty self explanatory. However, it should also be noted that before this PR the
unix_timestamp_valandunix_timestamp_list_valattributes ofValuewere never set. So there was a Proto type which was, as far as I can tell, stored incorrectly.Because this fixes a bug in how
UNIX_TIMESTAMPtypes are represented in the OnlineStore this change could result in a mix of Python types being returned forUNIX_TIMESTAMPfeatures in existing OnlineStores.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: